Review

juliusbrussee/cavekit/skills/review

作者 juliusbrussee7421e87d5b51无许可证1.1K 个星标收录于 2026年10月8日更新于 2026年10月8日仓库7周前更新

Adversarial senior review of the spec before any code is written. Constructs a skeptical reviewer whose authority comes from the codebase, §R research, and live best-practice — then tries to REFUTE the spec, not rubber-stamp it. Every finding cites evidence (file:line or source); unverifiable ones are flagged. Survivors harden §V; the run ends in an explicit go / no-go gate. Triggers before building anything high-blast-radius, when the user says "review the spec", "red-team this", "is this plan sound", "senior review", or invokes /ck:review.

AI 生成的概览

在编码前对规格说明进行对抗式资深评审,引用证据并以明确的放行或否决结论收尾。

功能
该技能在编写任何代码之前,对规格说明执行对抗式资深评审。它构建一个以代码库、前期研究和当前最佳实践为依据的怀疑型评审者,并从目标与现实、缺失的不变量、接口漂移、约束冲突、未覆盖的边界情况以及抽象层级等角度尝试反驳该规格。每条发现都附带证据,并被归类为 BLOCK、HARDEN 或 NOTE,最终给出明确的放行或否决结论以及草拟的加固测试条目。
适用场景
适用于构建高影响范围变更之前,例如共享模块、认证、数据、资金或公共 API 相关工作。当规格涉及其他代码所依赖的接口或不变量,或错误构建的代价高于一次评审的成本时,也适合使用。对于琐碎、可逆且易于理解的变更应跳过。
运行要求
仅为指令,不附带脚本。它需要一份包含目标、约束、接口、研究、不变量和测试等章节的书面规格,并可能读取代码库文件及获取外部来源以核实最佳实践主张。

review — refute the spec before build

Every finding cites evidence — file:line or a source. No evidence → flag [unverified]. Default to refuted: a flaw you cannot prove is a flaw you note, not one you wave through.

An LLM cannot self-correct on its own judgment — left alone it drifts or degrades. Review fixes that the only way that works: a separate skeptic anchored to an external oracle — the code, §R, the test suite, the docs. "Looks good" is not a review. A refutation attempt is.

WHEN TO REVIEW

  • Before /build on a high-blast-radius change (shared module, auth, data, money, public API).
  • Spec touched §I or §V that other code depends on.
  • Right-sizing says the cost of a wrong build > the cost of one review pass.

Skip for a trivial, reversible, well-understood change. Adversarial review on a typo hallucinates flaws & wastes the budget — the self-critique paradox is real.

PHASE 0 — CAPTURE

Read the spec: §G §C §I §R §V §T. Hold the whole thing. You review the spec, not your memory of the conversation.

PHASE 1 — CONSTRUCT THE SENIOR

Build a reviewer with real authority, not a generic critic:

  • Codebase — grep/read the modules this spec touches. What patterns, what invariants already hold?
  • §R — what did research establish? A spec decision that contradicts §R is a finding.
  • Live — for any best-practice claim you are unsure of, fetch it. An out-of-date assumption is a flaw.

A reviewer with no evidence is just an opinion. Earn the authority first.

PHASE 2 — REFUTE

Attack the spec on these axes. For each, try to find the case where it breaks:

  • Goal vs reality — does §G solve the actual problem, or a proxy?
  • Missing invariant — what can go wrong that no §V catches? (most findings live here)
  • Interface drift — does §I match what callers already expect? (cite the caller, file:line)
  • Constraint conflict — do two §C bullets contradict? does one fight §R?
  • Unowned edge — the input, ordering, failure, or concurrency case no §T covers.
  • Altitude — §T too vague to act on, or so granular it is just typing?

PHASE 3 — CLASSIFY

Each finding: evidence → claim → severity.

  • BLOCK — build on this spec ships a real defect. Must fix first.
  • HARDEN — add/sharpen a §V so the build cannot regress it.
  • NOTE — worth knowing, not blocking.

No evidence? Down-rank to NOTE & tag [unverified]. ⊥ inflate a hunch to BLOCK.

PHASE 4 — HARDEN §V & GATE

  • Each HARDEN finding → a draft §V line (testable, cites the §I/behavior it guards). Hand to spec to write.
  • End on an explicit gate:
## review verdictBLOCK: 1 — §I.api shape ≠ caller src/client.ts:40. fix §I before build.HARDEN: 2 — drafted V8 (idempotent refund), V9 (tx around dual write).NOTE: 1 — §T4 vague, split before /build.gate: NO-GO until BLOCK cleared. then /build §T after spec writes V8,V9.

GO or NO-GO, never a shrug. Review is the checkpoint that stops a confident wrong build.

BOUNDARIES

  • ⊥ write SPEC.md. Draft §V & hand to spec.
  • ⊥ pass a finding with no evidence as fact. Flag [unverified].
  • ⊥ review trivia. Right-size or skip.
  • ⊥ rewrite the user's intent. You harden the spec, you do not replace its goal.

来源与署名

来源:juliusbrussee/cavekit位于skills/review提交7421e87

许可证: 无许可证

内容归原作者所有。SourceWeft 从公开仓库中收录这些内容。

举报或申请下架